Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Move survey types back to main file #808

Closed
wants to merge 1 commit into from

Conversation

neilkakkar
Copy link
Collaborator

Changes

Fixes #807

Tested it works with the minimal reproduction here: https://github.com/pauldambra/test-posthog-import (thanks @pauldambra )

Just checking if this adversely affects the survey loader package 👀

...

Checklist

@neilkakkar neilkakkar added the bump patch Bump patch version when this PR gets merged label Sep 26, 2023
@github-actions
Copy link

Size Change: +1.07 kB (0%)

Total Size: 710 kB

Filename Size Change
dist/array.full.js 177 kB +268 B (0%)
dist/array.js 119 kB +268 B (0%)
dist/es.js 119 kB +268 B (0%)
dist/module.js 119 kB +268 B (0%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB
dist/surveys.js 23.6 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot find module 'posthog-surveys-types'" with posthog-js 1.77.3 and later
1 participant